Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky test #9682

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky test #9682

merged 1 commit into from
Sep 1, 2023
+6 −0

Conversation

dreamer-89
Copy link
Member

Description

Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky test as it has caused a flurry of gradle check failures. This test was probably missed in #8812 where remaining flaky tests were overridden in RemoteIndexRecoveryIT.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
Relates: #9580
Relates: #8919

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky test
eaed481 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 mentioned this pull request Sep 1, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change eaed481

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.basic.SearchWithRandomIOExceptionsIT.testRandomDirectoryIOExceptions
      1 org.opensearch.search.basic.SearchWithRandomIOExceptionsIT.classMethod
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testMultipleShards

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #9682 (eaed481) into main (04c90c7) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9682      +/-   ##
============================================
+ Coverage     71.15%   71.22%   +0.06%     
- Complexity    57727    57754      +27     
============================================
  Files          4800     4800              
  Lines        272047   272047              
  Branches      39703    39703              
============================================
+ Hits         193565   193755     +190     
+ Misses        62266    62041     -225     
- Partials      16216    16251      +35

see 504 files with indirect coverage changes

@dreamer-89
Copy link
Member Author

Request for review @linuxpi @sachinpkale @mch2 @kotwanikunal

@dreamer-89 dreamer-89 merged commit ff4b23b into opensearch-project:main Sep 1, 2023
14 of 38 checks passed
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Sep 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
@github-actions
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky t…
494e270 
…est (#9682)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit ff4b23b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 1, 2023
Merged
@linuxpi
Copy link
Collaborator

linuxpi commented Sep 1, 2023

This test was probably missed in #8812 where remaining flaky tests were overridden in RemoteIndexRecoveryIT

I think it started failing recently due to a bad merge, i went back in time on the main branch and it works perfectly fine. I am looking into this.

@dreamer-89 Thanks for muting for now.

kotwanikunal pushed a commit that referenced this pull request Sep 2, 2023
@opensearch-trigger-bot @github-actions
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky t…
58ae69d 
…est (#9682) (#9708)

(cherry picked from commit ff4b23b)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@dreamer-89 @kaushalmahi12
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky t…
956a8b2 
…est (opensearch-project#9682)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@dreamer-89 @brusic
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky t…
17186aa 
…est (opensearch-project#9682)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@dreamer-89 @shiv0408
[Remote Store] Mute RemoteIndexRecoveryIT.testReplicaRecovery flaky t…
40f9cd4 
…est (opensearch-project#9682)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@kiranprakash154 kiranprakash154 mentioned this pull request Apr 29, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-89 @linuxpi @mch2